Open
Conversation
|
Thanks for the pull request! I'm getting a few javascript errors with this commit though. It looks like you may have copy pasted the bind logic from the parallax background attribute to the parallax attribute without changing out some values. |
Author
|
Hi, thanks for the review. |
|
It looks like most of the correct directive values have been switched out, but I'm getting more errors while testing these changes. It looks like the parallax and parallaxBackground directives initially had a different attrs variable in the link function signature. I fixed the JS error by changing out the attrs variable with $attrs in the parallax directive, but that started throwing more errors in the unbind function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for this awesome lib.
I solved a memory leak you had (you didn't unregister the scroll and touch events).